linux-kernel - Re: [PATCH] net: bcmgenet: Don't claim WOL when its not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e527a328-0a65-bb1f-8d87-b25504f0b663@broadcom.com>
Date:   Thu, 10 Mar 2022 10:52:29 -0800
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Cc:     opendmb@...il.com, f.fainelli@...il.com, davem@...emloft.net,
        kuba@...nel.org, bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, pbrobinson@...il.com
Subject: Re: [PATCH] net: bcmgenet: Don't claim WOL when its not available

On 3/9/22 8:55 PM, Jeremy Linton wrote:
> Some of the bcmgenet platforms don't correctly support WOL, yet
> ethtool returns:
> 
> "Supports Wake-on: gsf"
> 
> which is false.
> 
> Ideally if there isn't a wol_irq, or there is something else that
> keeps the device from being able to wakeup it should display:
> 
> "Supports Wake-on: d"
> 
> This patch checks whether the device can wakup, before using the
> hard-coded supported flags. This corrects the ethtool reporting, as
> well as the WOL configuration because ethtool verifies that the mode
> is supported before attempting it.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
Fixes: c51de7f3976b ("net: bcmgenet: add Wake-on-LAN support code")

Thanks Jeremy!
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)