linux-kernel - Re: [PATCH] tcp: export symbol tcp_set_congestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310124825.159ce624@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Mar 2022 12:48:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Mingbao Sun <sunmingbao@....com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        tyler.sun@...l.com, ping.gan@...l.com, yanxiu.cai@...l.com,
        libin.zhang@...l.com, ao.sun@...l.com
Subject: Re: [PATCH] tcp: export symbol tcp_set_congestion_control

On Thu, 10 Mar 2022 21:48:30 +0800 Mingbao Sun wrote:
> Since the kernel API 'kernel_setsockopt' was removed, and since the
> function ‘tcp_set_congestion_control’ is just the real underlying guy
> handling this job, so it makes sense to get it exported.

Do you happen to have a reference to the commit which removed
kernel_setsockopt and the justification?  My knee jerk reaction
would the that's a better path than allowing in-kernel socket users 
to poke at internal functions even if that works as of today.