linux-kernel - Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YipkwW6rUbWweXn7@robh.at.kernel.org>
Date:   Thu, 10 Mar 2022 14:51:13 -0600
From:   Rob Herring <robh@...nel.org>
To:     Alifer Moraes <alifer.m@...iscite.com>
Cc:     linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        broonie@...nel.org, devicetree@...r.kernel.org,
        eran.m@...iscite.com, festevam@...il.com, lgirdwood@...il.com,
        linuxppc-dev@...ts.ozlabs.org, nicoleotsuka@...il.com,
        patches@...nsource.cirrus.com, perex@...ex.cz,
        pierluigi.p@...iscite.com, shengjiu.wang@...il.com, tiwai@...e.com,
        Xiubo.Lee@...il.com
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote:
> From: Pierluigi Passaro <pierluigi.p@...iscite.com>
> 
> The platform_data structure is not populated when using device trees.
> This patch adds optional dts properties to allow populating it:
> - gpio-cfg
> - mic-cfg
> - num-drc-cfgs
> - drc-cfg-regs
> - drc-cfg-names
> - num-retune-mobile-cfgs
> - retune-mobile-cfg-regs
> - retune-mobile-cfg-names
> - retune-mobile-cfg-rates

If you want to add all this, convert to DT schema first. 

They all need vendor prefixes for starters.

> 
> Signed-off-by: Pierluigi Passaro <pierluigi.p@...iscite.com>
> Signed-off-by: Alifer Moraes <alifer.m@...iscite.com>
> ---
>  .../devicetree/bindings/sound/wm8904.txt      |  53 ++++++++
>  sound/soc/codecs/wm8904.c                     | 113 +++++++++++++++++-

Binding changes go in their own patches.