linux-kernel - Re: [PATCH] kdb: Remove redundant module related references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiporeSIrkFg/YS8@bombadil.infradead.org>
Date:   Thu, 10 Mar 2022 13:07:57 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Aaron Tomlin <atomlin@...hat.com>, christophe.leroy@...roup.eu,
        hch@...radead.org, cl@...ux.com, mbenes@...e.cz,
        akpm@...ux-foundation.org, jeyu@...nel.org,
        linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
        void@...ifault.com, atomlin@...mlin.com, allen.lkml@...il.com,
        joe@...ches.com, msuchanek@...e.de, oleksandr@...alenko.name,
        jason.wessel@...driver.com, pmladek@...e.com
Subject: Re: [PATCH] kdb: Remove redundant module related references

On Wed, Mar 09, 2022 at 12:06:40PM +0000, Daniel Thompson wrote:
> On Tue, Mar 08, 2022 at 10:52:03AM +0000, Aaron Tomlin wrote:
> > Hi Luis, Christoph, Daniel,
> > 
> > Is this patch ok or would you rather another iteration of the series?
> > Either way is fine for me. Thanks.
> 
> Another iteration makes more sense to me.

Iteration yes, but separating the patches no into another series no.

> The removal of kdb_modules is semantically part of your module clean
> up patch set and should certainly be included in it.
> 
> The removal of the spurious #include's in other kdb files is a
> good change but it is fully independent of the module rework. AFAICT
> those fixes are good with or without your changes. This suggests
> these changes can be separate from the main patch set.

Small fixes get piled in first on the series. But this is not a fix.
This effort will not be merged separately too. This won't go into the
next merge window either, because:

1) There is no rush
2) It is too late as all this needs proper testing and
   its too late to claim enough testing

So given this is all related to the move I see no reason to treat
this as a separate series. Your review of the v11 would be nice.

  Luis