linux-kernel - Re: [PATCH v1 3/4] arm64: dts: marvell: Add Armada 98DX2530 SoC and RD-AC5X board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiqI9/Or4SL6NthP@lunn.ch>
Date:   Fri, 11 Mar 2022 00:25:43 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
        "kostap@...vell.com" <kostap@...vell.com>,
        "robert.marko@...tura.hr" <robert.marko@...tura.hr>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1 3/4] arm64: dts: marvell: Add Armada 98DX2530 SoC and
 RD-AC5X board

> >> +	mvDma {
> >> +		compatible = "marvell,mv_dma";
> >> +		memory-region = <&prestera_rsvd>;
> >> +		status = "okay";
> >> +	};
> > Is this different to the existing Marvell XOR engine?
> 
> Yes it has something to do with the DMA memory for the integrated L3 
> switch. Because that driver doesn't exist I'll probably remove this node 
> (and the other prestera node below) in v2.

The compatible itself is not so great, since it made me think of the
DMA engine in the SoC. So maybe when the driver is added, it could be
something like prestera_dma?

> >> +				sdhci0: sdhci@...c0000 {
> >> +					compatible = "marvell,ac5-sdhci", "marvell,armada-ap806-sdhci";
> > This additional compatible should be added to the existing binding
> > document.
> I'll see what differences there are with the ap806-sdhci. I might be 
> able to remove it.

It is actually good to have the additional compatible. You might not
spot a difference now, but sometime in the future you do find a
difference which you need to work around in the driver. Having the
compatible in place means you can just change the driver and existing
DT blobs, burnt into flash etc, don't need to change.

> >
> >> +			eth0: ethernet@...00 {
> >> +				compatible = "marvell,armada-ac5-neta";
> > So it is not compatible with plain nata?
> 
> There is some odd muxing setup where the serdes are either SGMII or PCIe 
> or can even be connected to the internal switch. Whether the Ethernet 
> driver needs to care about it I'm not sure.

Russell King probably knows more about this, but it sounds more like a
comphy issues, not neta. The comphy connects the MAC to a SERDES, and
that SERDES can be SGMII, PCIe or USB.

> >> +		nand: nand@...b0000 {
> >> +			compatible = "marvell,ac5-nand-controller";
> > The current NAND driver does not work?
> 
> This is one of the things I can't test on the board I have (uses eMMC 
> instead of NAND). Should I put "marvell,armada-8k-nand-controller" in as 
> a placeholder or leave the node out entirely?

I would leave it out if you cannot test it.

  Andrew