linux-kernel - Re: [PATCH -next] perf/marvell: cn10k Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 14:42:40 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Bharat Bhushan <bbhushan2@...vell.com>,
        <bbudiredla@...vell.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] perf/marvell: cn10k Fix build error without
 CONFIG_OF

On 2022/3/9 22:11, Arnd Bergmann wrote:
> On Wed, Mar 9, 2022 at 3:06 PM YueHaibing <yuehaibing@...wei.com> wrote:
>>
>> drivers/perf/marvell_cn10k_ddr_pmu.c:723:21: error: ‘cn10k_ddr_pmu_of_match’ undeclared here (not in a function); did you mean ‘cn10k_ddr_pmu_driver’?
>>          .of_match_table = cn10k_ddr_pmu_of_match,
>>                            ^~~~~~~~~~~~~~~~~~~~~~
>>
>> Use of_match_ptr() to fix this.
>>
>> Fixes: 7cf83e222bce ("perf/marvell: CN10k DDR performance monitor support")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> It's generally better to remove the #ifdef around the match table
> definition instead,
> which improves readability, and has no downsides on the machines this actually
> runs on, because CONFIG_OF is always enabled on arm64.

Ok， will do this in v2, thanks!
> 
>       Arnd
> .
>