linux-kernel - Re: [PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 07:22:54 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <jiapeng.chong@...ux.alibaba.com>
CC:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Claudiu.Beznea@...rochip.com>,
        <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] ASoC: atmel: mchp-pdmc: Remove unnecessary print function
 dev_err()

On 10.03.2022 02:22, Jiapeng Chong wrote:
> diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
> index c44636f6207d..2b48bd3434c7 100644
> --- a/sound/soc/atmel/mchp-pdmc.c
> +++ b/sound/soc/atmel/mchp-pdmc.c
> @@ -988,7 +988,6 @@ static int mchp_pdmc_probe(struct platform_device *pdev)
> 
>          irq = platform_get_irq(pdev, 0);
>          if (irq < 0) {
> -               dev_err(dev, "failed to get irq: %d\n", irq);
>                  return irq;
>          }

The braces should also be removed. With that addressed, you can add:

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Thanks!