linux-kernel - block/blk-mq.c:1241:9: sparse: sparse: cast from restricted req_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 08:56:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christoph Hellwig <hch@....de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Jens Axboe <axboe@...nel.dk>,
        Johannes Thumshirn <johannes.thumshirn@....com>
Subject: block/blk-mq.c:1241:9: sparse: sparse: cast from restricted
 req_flags_t

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   330f4c53d3c2d8b11d86ec03a964b86dc81452f5
commit: 4054cff92c357813b6861b622122b344990f7e31 block: remove blk-exec.c
date:   3 months ago
config: mips-randconfig-s032-20220309 (https://download.01.org/0day-ci/archive/20220310/202203100836.WQYjRe2U-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4054cff92c357813b6861b622122b344990f7e31
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 4054cff92c357813b6861b622122b344990f7e31
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   command-line: note: in included file:
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
   builtin:0:0: sparse: this was the original definition
   builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
   builtin:0:0: sparse: this was the original definition
   block/blk-mq.c:1071:36: sparse: sparse: cast from restricted blk_status_t
   block/blk-mq.c:1164:17: sparse: sparse: cast to restricted blk_status_t
>> block/blk-mq.c:1241:9: sparse: sparse: cast from restricted req_flags_t

vim +1241 block/blk-mq.c

6fca6a611c27f1 Christoph Hellwig 2014-05-28  1230  
2b053aca76b48e Bart Van Assche   2016-10-28  1231  void blk_mq_add_to_requeue_list(struct request *rq, bool at_head,
2b053aca76b48e Bart Van Assche   2016-10-28  1232  				bool kick_requeue_list)
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1233  {
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1234  	struct request_queue *q = rq->q;
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1235  	unsigned long flags;
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1236  
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1237  	/*
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1238  	 * We abuse this flag that is otherwise used by the I/O scheduler to
ff821d271415f1 Jens Axboe        2017-11-10  1239  	 * request head insertion from the workqueue.
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1240  	 */
e806402130c9c4 Christoph Hellwig 2016-10-20 @1241  	BUG_ON(rq->rq_flags & RQF_SOFTBARRIER);
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1242  
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1243  	spin_lock_irqsave(&q->requeue_lock, flags);
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1244  	if (at_head) {
e806402130c9c4 Christoph Hellwig 2016-10-20  1245  		rq->rq_flags |= RQF_SOFTBARRIER;
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1246  		list_add(&rq->queuelist, &q->requeue_list);
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1247  	} else {
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1248  		list_add_tail(&rq->queuelist, &q->requeue_list);
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1249  	}
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1250  	spin_unlock_irqrestore(&q->requeue_lock, flags);
2b053aca76b48e Bart Van Assche   2016-10-28  1251  
2b053aca76b48e Bart Van Assche   2016-10-28  1252  	if (kick_requeue_list)
2b053aca76b48e Bart Van Assche   2016-10-28  1253  		blk_mq_kick_requeue_list(q);
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1254  }
6fca6a611c27f1 Christoph Hellwig 2014-05-28  1255  

:::::: The code at line 1241 was first introduced by commit
:::::: e806402130c9c494e22c73ae9ead4e79d2a5811c block: split out request-only flags into a new namespace

:::::: TO: Christoph Hellwig <hch@....de>
:::::: CC: Jens Axboe <axboe@...com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org