linux-kernel - [PATCH] cifs: add a break after finding a new iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 10 Mar 2022 19:37:09 +0800
From:   Wan Jiabing <wanjiabing@...o.com>
To:     Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org
Cc:     kael_w@...com, Wan Jiabing <wanjiabing@...o.com>
Subject: [PATCH] cifs: add a break after finding a new iface

There should be a break after finding a new iface, otherwise the iface
would always be the head of the list after iterating.

Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
---
 fs/cifs/sess.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index fef087129c21..7802525a52ec 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -253,6 +253,7 @@ cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
 			continue;
 		}
 		kref_get(&iface->refcount);
+		break;
 	}
 
 	if (!iface) {
-- 
2.35.1