linux-kernel - Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hilsmey0h.wl-tiwai@suse.de>
Date:   Thu, 10 Mar 2022 14:29:50 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     huangwenhui <huangwenhuia@...ontech.com>
Cc:     perex@...ex.cz, tiwai@...e.com, jeremy.szu@...onical.com,
        hui.wang@...onical.com, wse@...edocomputers.com, cam@...-zeon.de,
        kailang@...ltek.com, tanureal@...nsource.cirrus.com, sami@...ne.fi,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

On Thu, 10 Mar 2022 14:03:01 +0100,
huangwenhui wrote:
> 
> On a HP 288 Pro G8, the front Mic could not be detected.
> 
> Signed-off-by: huangwenhui <huangwenhuia@...ontech.com>

Thanks for the patch.  Most of the changes look OK, but one thing I
still don't get:

> +	case HDA_FIXUP_ACT_INIT:
> +		alc_write_coef_idx(codec, 0x19, 0xa054);
> +		msleep(80);
> +		snd_hda_codec_write(codec, hp_pin, 0,
> +			    AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);

Why this unconditional unmute is required for fixing the mic problem?


Takashi