linux-kernel - Re: [PATCHv2 00/10] ext4: Improve FC trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310213356.3948cfb7@gandalf.local.home>
Date:   Thu, 10 Mar 2022 21:33:56 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>,
        "Theodore Ts'o" <tytso@....edu>,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 00/10] ext4: Improve FC trace events

On Fri, 11 Mar 2022 07:49:31 +0530
Ritesh Harjani <riteshh@...ux.ibm.com> wrote:

> > # cat /sys/kernel/tracing/events/ext4/ext4_fc_commit_stop/format  
> 
> I think you meant ext4_fc_stats.

Sure.

> 
> >
> > and show me what it outputs.  
> 
> root@...u:/home/qemu# cat /sys/kernel/tracing/events/ext4/ext4_fc_stats/format
> name: ext4_fc_stats
> ID: 986
> format:
>         field:unsigned short common_type;       offset:0;       size:2; signed:0;
>         field:unsigned char common_flags;       offset:2;       size:1; signed:0;
>         field:unsigned char common_preempt_count;       offset:3;       size:1; signed:0;
>         field:int common_pid;   offset:4;       size:4; signed:1;
> 
>         field:dev_t dev;        offset:8;       size:4; signed:0;
>         field:unsigned int fc_ineligible_rc[EXT4_FC_REASON_MAX];        offset:12;      size:36;        signed:0;

Bah, the above tells us how many items, and the TRACE_DEFINE_ENUM() doesn't
modify this part of the file.

I could update it to do so though.

-- Steve


>         field:unsigned long fc_commits; offset:48;      size:8; signed:0;
>         field:unsigned long fc_ineligible_commits;      offset:56;      size:8; signed:0;
>         field:unsigned long fc_numblks; offset:64;      size:8; signed:0;