linux-kernel - Re: [PATCH] remove reference to the removed config NFSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54AB09CE-9345-4C8C-84F8-FA5C8D9F9EB9@oracle.com>
Date:   Fri, 11 Mar 2022 15:54:39 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
CC:     Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] remove reference to the removed config NFSD_V3



> On Mar 11, 2022, at 10:23 AM, Chuck Lever III <chuck.lever@...cle.com> wrote:
> 
> 
> 
>> On Mar 11, 2022, at 9:39 AM, Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
>> 
>> Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config
>> NFSD_V3, but misses one reference in fs/Kconfig.
>> 
>> Remove this remaining reference to the removed config symbol.
>> 
>> This issue was discovered with ./scripts/checkkconfigsymbols.py.
>> 
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>> ---
>> Chuck, please pick this quick fix to your commit in linux-next.
>> 
>> fs/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/fs/Kconfig b/fs/Kconfig
>> index 7f2455e8e18a..ec2cf8ccd170 100644
>> --- a/fs/Kconfig
>> +++ b/fs/Kconfig
>> @@ -344,7 +344,7 @@ config LOCKD
>> 
>> config LOCKD_V4
>> 	bool
>> -	depends on NFSD_V3 || NFS_V3
>> +	depends on NFS_V3
> 
> Actually, I think:
> 
> 	depends on NFSD || NFS_V3
> 
> is more correct. LOCKD_V4 now needs to be enabled whenever
> the server is enabled, since NFSv3 support in the server is
> now always enabled.

I've squashed this change into "NFSD: Remove CONFIG_NFSD_V3".
Thanks for reporting it, Lukas!


>> 	depends on FILE_LOCKING
>> 	default y
>> 
>> -- 
>> 2.17.1
>> 
> 
> --
> Chuck Lever

--
Chuck Lever