linux-kernel - Re: [PATCH] ASoC: soc-compress: Change the check for codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220311155314.GK38351@ediswmail.ad.cirrus.com>
Date:   Fri, 11 Mar 2022 15:53:14 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
CC:     <dan.carpenter@...cle.com>, <vkoul@...nel.org>,
        <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ASoC: soc-compress: Change the check for codec_dai

On Thu, Mar 10, 2022 at 11:00:41AM +0800, Jiasheng Jiang wrote:
> It should be better to reverse the check on codec_dai
> and returned early in order to be easier to understand.
> 
> Fixes: de2c6f98817f ("ASoC: soc-compress: prevent the potentially use of null pointer")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles