linux-kernel - Re: [PATCH] ARM: Spectre-BHB: provide empty stub for non-config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yiui4HUz8RxHMdYf@shell.armlinux.org.uk>
Date:   Fri, 11 Mar 2022 19:28:32 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, patches@...linux.org.uk
Subject: Re: [PATCH] ARM: Spectre-BHB: provide empty stub for non-config

On Fri, Mar 11, 2022 at 11:18:20AM -0800, Randy Dunlap wrote:
> When CONFIG_GENERIC_CPU_VULNERABILITIES is not set, references
> to spectre_v2_update_state() cause a build error, so provide an
> empty stub for that function when the Kconfig option is not set.
> 
> Fixes this build error:
> 
> arm-linux-gnueabi-ld: arch/arm/mm/proc-v7-bugs.o: in function `cpu_v7_bugs_init':
> proc-v7-bugs.c:(.text+0x52): undefined reference to `spectre_v2_update_state'
> arm-linux-gnueabi-ld: proc-v7-bugs.c:(.text+0x82): undefined reference to `spectre_v2_update_state'
> 
> Fixes: b9baf5c8c5c3 ("ARM: Spectre-BHB workaround")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>

Acked-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

I'd suggest sending this direct to Linus as I've been doing with the
other fixes for Spectre BHB. Trying to fit it now into a pull request
is just going to be very messy.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!