linux-kernel - Re: [PATCH v4 0/2] x86/mce: Handle error injection failure in mce-inject module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2d7c8fd-5178-a40b-7f15-5e0736388aa4@amd.com>
Date:   Fri, 11 Mar 2022 14:55:39 -0600
From:   "Koralahalli Channabasappa, Smita" <skoralah@....com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
        x86@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Tony Luck <tony.luck@...el.com>, "H . Peter Anvin" <hpa@...or.com>,
        Yazen Ghannam <yazen.ghannam@....com>
Subject: Re: [PATCH v4 0/2] x86/mce: Handle error injection failure in
 mce-inject module

Hi all,

Do you have any comments that needs to be addressed on these set of patches?

Thanks,
Smita.

On 2/14/22 5:36 PM, Smita Koralahalli wrote:

> This set of patches handles a scenario where error injection fails silently
> on mce-inject module and returns appropriate error code to userspace.
>
> Error injection fails if the platform enforces write ignored behavior on
> status registers and the first patch checks for writes ignored from
> MCA_STATUS register and returns appropriate error code to user.
>
> The second patch assigns and returns the error code to userspace when none
> of the CPUs are online.
>
> Smita Koralahalli (2):
>    x86/mce: Check for writes ignored in MCA_STATUS register
>    x86/mce/mce-inject: Return appropriate error code if CPUs are offline
>
>   arch/x86/kernel/cpu/mce/core.c   |  1 +
>   arch/x86/kernel/cpu/mce/inject.c | 42 +++++++++++++++++++++++++++++---
>   2 files changed, 39 insertions(+), 4 deletions(-)
>