linux-kernel - Re: [PATCH v4 0/3] x86/mce: Support extended MCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6bcde0a-8232-4384-4e48-156fee7a229e@amd.com>
Date:   Fri, 11 Mar 2022 15:00:43 -0600
From:   "Koralahalli Channabasappa, Smita" <skoralah@....com>
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
        x86@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Tony Luck <tony.luck@...el.com>, "H . Peter Anvin" <hpa@...or.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        Yazen Ghannam <yazen.ghannam@....com>
Subject: Re: [PATCH v4 0/3] x86/mce: Support extended MCA_ADDR address on SMCA
 systems

Hi all,

Do you have any comments that needs to be addressed on these set of patches?

Thanks,
Smita

On 2/25/22 1:33 PM, Smita Koralahalli wrote:

> This series of patches adds support for extended physical address on newer
> AMD processors such as AMD 'Milan'.
>
> The first patch provides a fix to avoid unnecessary padding in mce_bank
> struct.
>
> The second patch defines a separate helper function to extract
> MCA_ADDR[ErrorAddr].
>
> Finally, the last patch adds support for extended ErrorAddr bits in
> MCA_ADDR.
>
> Link:
> https://lkml.kernel.org/r/20220211223442.254489-1-Smita.KoralahalliChannabasappa@amd.com
>
> Smita Koralahalli (3):
>    x86/mce: Avoid unnecessary padding in struct mce_bank
>    x86/mce: Define function to extract ErrorAddr from MCA_ADDR
>    x86/mce: Add support for Extended Physical Address MCA changes
>
>   arch/x86/include/asm/mce.h         |  4 ++++
>   arch/x86/kernel/cpu/mce/amd.c      | 35 ++++++++++++++++++++++--------
>   arch/x86/kernel/cpu/mce/core.c     | 20 +++++------------
>   arch/x86/kernel/cpu/mce/internal.h | 16 ++++++++++++++
>   4 files changed, 52 insertions(+), 23 deletions(-)
>