linux-kernel - [PATCH] user_events: Use alloc_pages instead of kzalloc for register pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220311223028.1865-1-beaub@linux.microsoft.com>
Date:   Fri, 11 Mar 2022 14:30:28 -0800
From:   Beau Belgrave <beaub@...ux.microsoft.com>
To:     rostedt@...dmis.org, mhiramat@...nel.org
Cc:     anders.roxell@...aro.org, linux-trace-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
        beaub@...ux.microsoft.com
Subject: [PATCH] user_events: Use alloc_pages instead of kzalloc for register pages

kzalloc virtual addresses do not work with SetPageReserved, use the
actual page virtual addresses instead via alloc_pages.

The issue is reported when booting with user_events and
DEBUG_VM_PGFLAGS=y.

Link: https://lore.kernel.org/linux-trace-devel/CADYN=9+xY5Vku3Ws5E9S60SM5dCFfeGeRBkmDFbcxX0ZMoFing@mail.gmail.com/#R

Reported-by: Anders Roxell <anders.roxell@...aro.org>
Signed-off-by: Beau Belgrave <beaub@...ux.microsoft.com>
---
 kernel/trace/trace_events_user.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
index 2b5e9fdb63a0..59c900789757 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -1587,16 +1587,20 @@ static void set_page_reservations(bool set)
 static int __init trace_events_user_init(void)
 {
 	int ret;
+	struct page *register_pages;
 
 	/* Zero all bits beside 0 (which is reserved for failures) */
 	bitmap_zero(page_bitmap, MAX_EVENTS);
 	set_bit(0, page_bitmap);
 
-	register_page_data = kzalloc(MAX_EVENTS, GFP_KERNEL);
+	register_pages = alloc_pages(GFP_KERNEL | __GFP_ZERO,
+				     get_order(MAX_EVENTS));
 
-	if (!register_page_data)
+	if (!register_pages)
 		return -ENOMEM;
 
+	register_page_data = page_address(register_pages);
+
 	set_page_reservations(true);
 
 	ret = create_user_tracefs();
@@ -1604,7 +1608,7 @@ static int __init trace_events_user_init(void)
 	if (ret) {
 		pr_warn("user_events could not register with tracefs\n");
 		set_page_reservations(false);
-		kfree(register_page_data);
+		__free_pages(register_pages, get_order(MAX_EVENTS));
 		return ret;
 	}
 

base-commit: 864ea0e10cc90416a01b46f0d47a6f26dc020820
-- 
2.17.1