| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Mar 2022 07:05:09 +0800
From: kernel test robot <lkp@...el.com>
To: Jiri Pirko <jiri@...dia.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [jpirko-mlxsw:jiri_devel_linecards 39/40]
drivers/net/netdevsim/dev.c:117:26: error: too few arguments to function
'devlink_linecard_device_create'
tree: https://github.com/jpirko/linux_mlxsw jiri_devel_linecards
head: c234507fcad181742ea04ca881338ee694735a74
commit: 526aaa97a43d0506e5c914890dd9b0c78276d625 [39/40] TMP: devlink device type
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20220312/202203120723.CQQLnB8w-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/526aaa97a43d0506e5c914890dd9b0c78276d625
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_linecards
git checkout 526aaa97a43d0506e5c914890dd9b0c78276d625
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/net/netdevsim/dev.c: In function 'nsim_dev_linecard_devices_create':
drivers/net/netdevsim/dev.c:119:57: error: passing argument 4 of 'devlink_linecard_device_create' from incompatible pointer type [-Werror=incompatible-pointer-types]
119 | nsim_dev_linecard);
| ^~~~~~~~~~~~~~~~~
| |
| struct nsim_dev_linecard *
In file included from drivers/net/netdevsim/dev.c:29:
include/net/devlink.h:1580:44: note: expected 'const char *' but argument is of type 'struct nsim_dev_linecard *'
1580 | const char *type, void *priv);
| ~~~~~~~~~~~~^~~~
>> drivers/net/netdevsim/dev.c:117:26: error: too few arguments to function 'devlink_linecard_device_create'
117 | device = devlink_linecard_device_create(nsim_dev_linecard->devlink_linecard,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/netdevsim/dev.c:29:
include/net/devlink.h:1577:1: note: declared here
1577 | devlink_linecard_device_create(struct devlink_linecard *linecard,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/devlink_linecard_device_create +117 drivers/net/netdevsim/dev.c
de611295f39ec6 Jiri Pirko 2021-05-05 100
de611295f39ec6 Jiri Pirko 2021-05-05 101 static int
de611295f39ec6 Jiri Pirko 2021-05-05 102 nsim_dev_linecard_devices_create(struct nsim_dev_linecard *nsim_dev_linecard)
de611295f39ec6 Jiri Pirko 2021-05-05 103 {
de611295f39ec6 Jiri Pirko 2021-05-05 104 struct devlink_linecard_device *device;
de611295f39ec6 Jiri Pirko 2021-05-05 105 char *component_name;
de611295f39ec6 Jiri Pirko 2021-05-05 106 int err;
de611295f39ec6 Jiri Pirko 2021-05-05 107 int i;
de611295f39ec6 Jiri Pirko 2021-05-05 108
de611295f39ec6 Jiri Pirko 2021-05-05 109 snprintf(nsim_dev_linecard->device_component_name,
de611295f39ec6 Jiri Pirko 2021-05-05 110 sizeof(nsim_dev_linecard->device_component_name), "lc%u_dev0",
de611295f39ec6 Jiri Pirko 2021-05-05 111 nsim_dev_linecard->linecard_index);
de611295f39ec6 Jiri Pirko 2021-05-05 112 component_name = nsim_dev_linecard->device_component_name;
de611295f39ec6 Jiri Pirko 2021-05-05 113
de611295f39ec6 Jiri Pirko 2021-05-05 114 for (i = 0; i < NSIM_DEV_LINECARD_DEVICE_COUNT; i++) {
de611295f39ec6 Jiri Pirko 2021-05-05 115 if (i > 0)
de611295f39ec6 Jiri Pirko 2021-05-05 116 component_name = NULL;
de611295f39ec6 Jiri Pirko 2021-05-05 @117 device = devlink_linecard_device_create(nsim_dev_linecard->devlink_linecard,
de611295f39ec6 Jiri Pirko 2021-05-05 118 i, component_name,
de611295f39ec6 Jiri Pirko 2021-05-05 119 nsim_dev_linecard);
de611295f39ec6 Jiri Pirko 2021-05-05 120 if (IS_ERR(device)) {
de611295f39ec6 Jiri Pirko 2021-05-05 121 err = PTR_ERR(device);
de611295f39ec6 Jiri Pirko 2021-05-05 122 goto rollback;
de611295f39ec6 Jiri Pirko 2021-05-05 123 }
de611295f39ec6 Jiri Pirko 2021-05-05 124 nsim_dev_linecard->devlink_device[i] = device;
de611295f39ec6 Jiri Pirko 2021-05-05 125 }
de611295f39ec6 Jiri Pirko 2021-05-05 126 return 0;
de611295f39ec6 Jiri Pirko 2021-05-05 127
de611295f39ec6 Jiri Pirko 2021-05-05 128 rollback:
de611295f39ec6 Jiri Pirko 2021-05-05 129 for (i--; i >= 0; i--) {
de611295f39ec6 Jiri Pirko 2021-05-05 130 device = nsim_dev_linecard->devlink_device[i];
de611295f39ec6 Jiri Pirko 2021-05-05 131 devlink_linecard_device_destroy(nsim_dev_linecard->devlink_linecard,
de611295f39ec6 Jiri Pirko 2021-05-05 132 device);
de611295f39ec6 Jiri Pirko 2021-05-05 133 }
de611295f39ec6 Jiri Pirko 2021-05-05 134 return err;
de611295f39ec6 Jiri Pirko 2021-05-05 135 }
de611295f39ec6 Jiri Pirko 2021-05-05 136
:::::: The code at line 117 was first introduced by commit
:::::: de611295f39ec6f57ce11e67db048ffed43f0181 netdevsim: create couple of devices on each linecard
:::::: TO: Jiri Pirko <jiri@...dia.com>
:::::: CC: Jiri Pirko <jiri@...dia.com>
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists