linux-kernel - [PATCH 0/3] NVMe/TCP: support specifying the congestion-control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220311030113.73384-1-sunmingbao@tom.com>
Date:   Fri, 11 Mar 2022 11:01:10 +0800
From:   Mingbao Sun <sunmingbao@....com>
To:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     sunmingbao@....com, tyler.sun@...l.com, ping.gan@...l.com,
        yanxiu.cai@...l.com, libin.zhang@...l.com, ao.sun@...l.com
Subject: [PATCH 0/3] NVMe/TCP: support specifying the congestion-control

From: Mingbao Sun <tyler.sun@...l.com>

Hi all,

congestion-control could have a noticeable impaction on the
performance of TCP-based communications. This is of course true
to NVMe_over_TCP.

Different congestion-controls (e.g., cubic, dctcp) are suitable for
different scenarios. Proper adoption of congestion control would benefit
the performance. On the contrary, the performance could be destroyed.

Though we can specify the congestion-control of NVMe_over_TCP via
writing '/proc/sys/net/ipv4/tcp_congestion_control', but this also
changes the congestion-control of all the future TCP sockets that
have not been explicitly assigned the congestion-control, thus bringing
potential impaction on their performance.

So it makes sense to make NVMe_over_TCP support specifying the
congestion-control.

patch 1/3 export a symbol on behalf of the following ones.
patch 2/3 addresses the NVMe/TCP host side.
patch 3/3 addresses the NVMe/TCP target side.

Since the change made to netdev is pretty simple, so the patch
is generated against nvme-5.18 of the nvme.git.

Mingbao Sun (3):
  tcp: export symbol tcp_set_congestion_control
  nvme-tcp: support specifying the congestion-control
  nvmet-tcp: support specifying the congestion-control

 drivers/nvme/host/fabrics.c    | 12 +++++++++++
 drivers/nvme/host/fabrics.h    |  2 ++
 drivers/nvme/host/tcp.c        | 15 +++++++++++++-
 drivers/nvme/target/configfs.c | 37 ++++++++++++++++++++++++++++++++++
 drivers/nvme/target/nvmet.h    |  1 +
 drivers/nvme/target/tcp.c      | 11 ++++++++++
 net/ipv4/tcp_cong.c            |  1 +
 7 files changed, 78 insertions(+), 1 deletion(-)

-- 
2.26.2