linux-kernel - Re: [PATCH] ASoC: max98390: Add reset gpio control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Mar 2022 14:53:02 +0900
From:   Lee Steve <steve.lee.analog@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     "Sa, Nuno" <Nuno.Sa@...log.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "ckeepax@...nsource.cirrus.com" <ckeepax@...nsource.cirrus.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "rf@...nsource.wolfsonmicro.com" <rf@...nsource.wolfsonmicro.com>,
        "shumingf@...ltek.com" <shumingf@...ltek.com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "dmurphy@...com" <dmurphy@...com>,
        "jack.yu@...ltek.com" <jack.yu@...ltek.com>,
        "steves.lee@...imintegrated.com" <steves.lee@...imintegrated.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: Re: [PATCH] ASoC: max98390: Add reset gpio control

On Thu, Mar 10, 2022 at 8:29 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Thu, Mar 10, 2022 at 08:48:09AM +0000, Sa, Nuno wrote:
>
> > > +   max98390->reset_gpio = of_get_named_gpio(i2c-
> > > >dev.of_node,
> > > +                                           "maxim,reset-gpios", 0);
>
> > Why not using devm_gpiod_get_optional()? We could request the pin
> > already in the asserted state and make the code slightly better...
>
> Yes, and it'd support other firmware interfaces too.  We also need an
> update to the binding document covering the new property.
>
> Might also be worth putting the device into reset when unloading the
> driver, though that's not essential.

I will check and update v2 patch.