linux-kernel - Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b9e7ef4-10b9-1061-d12f-76fd62e1ae2d@redhat.com>
Date:   Fri, 11 Mar 2022 08:18:51 +0200
From:   Mika Penttilä <mpenttil@...hat.com>
To:     John Hubbard <jhubbard@...dia.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Cc:     apopple@...dia.com, rcampbell@...dia.com, jgg@...pe.ca,
        vbabka@...e.cz
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice
 instead of char dev



On 11.3.2022 8.15, John Hubbard wrote:
> On 3/10/22 19:30, mpenttil@...hat.com wrote:
>> From: Mika Penttilä <mpenttil@...hat.com>
>>
>> HMM selftests use an in-kernel pseudo device to emulate device private
>> memory. The pseudo device registers a major device range for two pseudo
>> device instances. User space has a script that reads /proc/devices in
>> order to find the assigned major number, and sends that to mknod(1),
>> once for each node.
>>
>> This duplicates a fair amount of boilerplate that misc device can do
>> instead.
>>
>> Change this to use misc device, which makes the device node names appear
>> for us. This also enables udev-like processing if desired.
>>
>> Delete the /proc/devices parsing from the user-space test script, now
>> that it is unnecessary.
>>
>> v2:
>>          - Cleanups per review comments from John Hubbard
>>          - Added Tested-by and Ccs
> 
> The three lines above, starting with "v2:", belong after the "---". That
> way, they are not included in the commit log. That's the convention.
> 
> I think Andrew can fix it up for you, no need to spin a new patch for
> that.
> 
> Anyway, this looks good now, so please feel free to add:
> 
> Reviewed-by: John Hubbard <jhubbard@...dia.com>


Thanks John!

> 
> 
> thanks,