linux-kernel - RE: [PATCH -next] ice: fix return value check in ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3367F780F7761EC6EBD87B2EFC0C9@BYAPR11MB3367.namprd11.prod.outlook.com>
Date:   Fri, 11 Mar 2022 06:34:53 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>
Subject: RE: [PATCH -next] ice: fix return value check in ice_gnss.c



> -----Original Message-----
> From: Yang Yingliang <yangyingliang@...wei.com>
> Sent: Saturday, March 5, 2022 2:35 PM
> To: linux-kernel@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; kuba@...nel.org; davem@...emloft.net;
> Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kolacinski, Karol
> <karol.kolacinski@...el.com>
> Subject: [PATCH -next] ice: fix return value check in ice_gnss.c
> 
> kthread_create_worker() and tty_alloc_driver() return ERR_PTR() and never
> return NULL. The NULL test in the return value check should be replaced with
> IS_ERR().
> 
> Fixes: 43113ff73453 ("ice: add TTY for GNSS module for E810T device")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_gnss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at Intel)