linux-kernel - [djwong-xfs:vectorized-scrub 95/346] fs/xfs/xfs_mount.h:78:43: error: expected identifier or '(' before 'void'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 11 Mar 2022 15:11:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     kbuild-all@...ts.01.org,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: [djwong-xfs:vectorized-scrub 95/346] fs/xfs/xfs_mount.h:78:43:
 error: expected identifier or '(' before 'void'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git vectorized-scrub
head:   38ef7fcbbc5b33107155955dcd6ed6c92f4ceb91
commit: af5ea75e919d339b63fdbac6de44242559497a78 [95/346] xfs: track file link count updates during live nlinks fsck
config: csky-randconfig-r036-20220310 (https://download.01.org/0day-ci/archive/20220311/202203111528.SKeFyJjX-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=af5ea75e919d339b63fdbac6de44242559497a78
        git remote add djwong-xfs https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
        git fetch --no-tags djwong-xfs vectorized-scrub
        git checkout af5ea75e919d339b63fdbac6de44242559497a78
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from fs/xfs/xfs_inode.c:14:
>> fs/xfs/xfs_mount.h:78:43: error: expected identifier or '(' before 'void'
      78 | # define XFS_HOOKS_SWITCH_DEFINE(name)  ((void)0)
         |                                           ^~~~
   fs/xfs/xfs_inode.c:952:1: note: in expansion of macro 'XFS_HOOKS_SWITCH_DEFINE'
     952 | XFS_HOOKS_SWITCH_DEFINE(xfs_nlinks_hooks_switch);
         | ^~~~~~~~~~~~~~~~~~~~~~~
>> fs/xfs/xfs_mount.h:78:48: error: expected ')' before numeric constant
      78 | # define XFS_HOOKS_SWITCH_DEFINE(name)  ((void)0)
         |                                                ^
   fs/xfs/xfs_inode.c:952:1: note: in expansion of macro 'XFS_HOOKS_SWITCH_DEFINE'
     952 | XFS_HOOKS_SWITCH_DEFINE(xfs_nlinks_hooks_switch);
         | ^~~~~~~~~~~~~~~~~~~~~~~


vim +78 fs/xfs/xfs_mount.h

f5548336fb5444 Darrick J. Wong 2022-01-06  64  
f5548336fb5444 Darrick J. Wong 2022-01-06  65  /*
f5548336fb5444 Darrick J. Wong 2022-01-06  66   * If hooks and jump labels are enabled, we use jump labels (aka patching of
f5548336fb5444 Darrick J. Wong 2022-01-06  67   * the code segment) to avoid the minute overhead of calling an empty notifier
f5548336fb5444 Darrick J. Wong 2022-01-06  68   * chain when we know there are no callers.  If hooks are enabled without jump
f5548336fb5444 Darrick J. Wong 2022-01-06  69   * labels, hardwire the predicate to true because calling an empty srcu
f5548336fb5444 Darrick J. Wong 2022-01-06  70   * notifier chain isn't so expensive.
f5548336fb5444 Darrick J. Wong 2022-01-06  71   */
f5548336fb5444 Darrick J. Wong 2022-01-06  72  #if defined(CONFIG_JUMP_LABEL) && defined(CONFIG_XFS_LIVE_HOOKS)
f5548336fb5444 Darrick J. Wong 2022-01-06  73  # define XFS_HOOKS_SWITCH_DEFINE(name)	DEFINE_STATIC_KEY_FALSE(name)
f5548336fb5444 Darrick J. Wong 2022-01-06  74  # define xfs_hooks_switch_on(name)	static_branch_inc(name)
f5548336fb5444 Darrick J. Wong 2022-01-06  75  # define xfs_hooks_switch_off(name)	static_branch_dec(name)
f5548336fb5444 Darrick J. Wong 2022-01-06  76  # define xfs_hooks_switched_on(name)	static_branch_unlikely(name)
f5548336fb5444 Darrick J. Wong 2022-01-06  77  #elif defined(CONFIG_XFS_LIVE_HOOKS)
f5548336fb5444 Darrick J. Wong 2022-01-06 @78  # define XFS_HOOKS_SWITCH_DEFINE(name)	((void)0)
f5548336fb5444 Darrick J. Wong 2022-01-06  79  # define xfs_hooks_switch_on(name)	((void)0)
f5548336fb5444 Darrick J. Wong 2022-01-06  80  # define xfs_hooks_switch_off(name)	((void)0)
f5548336fb5444 Darrick J. Wong 2022-01-06  81  # define xfs_hooks_switched_on(name)	(true)
f5548336fb5444 Darrick J. Wong 2022-01-06  82  #else
f5548336fb5444 Darrick J. Wong 2022-01-06  83  # define XFS_HOOKS_SWITCH_DEFINE(name)	((void)0)
f5548336fb5444 Darrick J. Wong 2022-01-06  84  # define xfs_hooks_switch_on(name)	((void)0)
f5548336fb5444 Darrick J. Wong 2022-01-06  85  # define xfs_hooks_switch_off(name)	((void)0)
f5548336fb5444 Darrick J. Wong 2022-01-06  86  # define xfs_hooks_switched_on(name)	(false)
f5548336fb5444 Darrick J. Wong 2022-01-06  87  #endif /* JUMP_LABEL && XFS_LIVE_HOOKS */
f5548336fb5444 Darrick J. Wong 2022-01-06  88  

:::::: The code at line 78 was first introduced by commit
:::::: f5548336fb5444559e7759a30e560ecf7cdbc03d xfs: allow scrub to hook metadata updates in other writers

:::::: TO: Darrick J. Wong <djwong@...nel.org>
:::::: CC: Darrick J. Wong <djwong@...nel.org>

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org