linux-kernel - Re: [PATCH] video: fbdev: kyro: make read-only array ODValues static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8107fc3-2d89-eaa1-bde6-2d1e848147fd@gmx.de>
Date:   Fri, 11 Mar 2022 08:30:18 +0100
From:   Helge Deller <deller@....de>
To:     Colin Ian King <colin.i.king@...il.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: kyro: make read-only array ODValues static
 const

On 3/8/22 21:23, Colin Ian King wrote:
> Don't populate the read-only array ODValues on the stack but
> instead make it static const. Also makes the object code a little
> smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>
> ---
>  drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> index 21875d3c2dc2..ffeb355c8b50 100644
> --- a/drivers/video/fbdev/kyro/STG4000InitDevice.c
> +++ b/drivers/video/fbdev/kyro/STG4000InitDevice.c
> @@ -124,7 +124,7 @@ u32 ProgramClock(u32 refClock,
>  	u32 ulScore, ulPhaseScore, ulVcoScore;
>  	u32 ulTmp = 0, ulVCO;
>  	u32 ulScaleClockReq, ulMinClock, ulMaxClock;
> -	u32 ODValues[] = { 1, 2, 0 };
> +	static const u32 ODValues[] = { 1, 2, 0 };

applied, but I made this:
	static const unsigned char

Thanks!
Helge

>
>  	/* Translate clock in Hz */
>  	coreClock *= 100;	/* in Hz */