lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2c4ed430-efc9-1328-b630-9b951f87a5b1@kernel.org>
Date:   Fri, 11 Mar 2022 16:23:58 +0800
From:   Chao Yu <chao@...nel.org>
To:     Gao Xiang <hsiangkao@...ux.alibaba.com>,
        linux-erofs@...ts.ozlabs.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] erofs: silence warnings related to impossible m_plen

On 2022/3/11 1:34, Gao Xiang wrote:
> Dan reported two smatch warnings [1],
> .. warn: should '1 << lclusterbits' be a 64 bit type?
> .. warn: should 'm->compressedlcs << lclusterbits' be a 64 bit type?
> 
> In practice, m_plen cannot be more than 1MiB due to on-disk constraint
> for the compression mode, so we're always safe here.
> 
> In order to make static analyzers happy and don't report again,
> let's silence them instead.
> 
> [1] https://lore.kernel.org/r/202203091002.lJVzsX6e-lkp@intel.com
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ