linux-kernel - Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <s5ho82cevra.wl-tiwai@suse.de>
Date:   Fri, 11 Mar 2022 09:30:49 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "huangwenhui" <huangwenhuia@...ontech.com>
Cc:     "perex" <perex@...ex.cz>, "tiwai" <tiwai@...e.com>,
        "jeremy.szu" <jeremy.szu@...onical.com>,
        "hui.wang" <hui.wang@...onical.com>,
        "wse" <wse@...edocomputers.com>, "cam" <cam@...-zeon.de>,
        "kailang" <kailang@...ltek.com>,
        "tanureal" <tanureal@...nsource.cirrus.com>,
        "sami" <sami@...ne.fi>, "alsa-devel" <alsa-devel@...a-project.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671

On Fri, 11 Mar 2022 02:20:42 +0100,
huangwenhui wrote:
> 
> Hi  Takashi,
> 
> if adjusting the mixer element or replugging the headset, the headphone would
> be unmuted.
> But most users hope that the default state is unmuted.
> Should this unconditional unmute be required?

It's the standard behavior for most of ALSA drivers.

The initial mute state is rather controlled via alsactl, restoring the
previous state.  Also, the sound server like PulseAudio or pipewire
does unmute automatically.  If this doesn't work as expected, that's a
more problem to diagnose.


Takashi

> 
> Thanks.
> 
> ------------------ Original ------------------
> From:  "Takashi Iwai"<tiwai@...e.de>;
> Date:  Thu, Mar 10, 2022 10:03 PM
> To:  "黄文辉"<huangwenhuia@...ontech.com>;
> Cc:  "perex"<perex@...ex.cz>; "tiwai"<tiwai@...e.com>; "jeremy.szu"
> <jeremy.szu@...onical.com>; "hui.wang"<hui.wang@...onical.com>; "wse"
> <wse@...edocomputers.com>; "cam"<cam@...-zeon.de>; "kailang"
> <kailang@...ltek.com>; "tanureal"<tanureal@...nsource.cirrus.com>; "sami"
> <sami@...ne.fi>; "alsa-devel"<alsa-devel@...a-project.org>; "linux-kernel"
> <linux-kernel@...r.kernel.org>;
> Subject:  Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> machine with alc671
>  
> On Thu, 10 Mar 2022 14:58:36 +0100,
> huangwenhui wrote:
> >
> > Hi  Takashi,
> >
> > Thank you for your reply.
> >
> > When booting with plugged headset, the headphone will be muted.
> 
> The muted state is the default behavior.  Wouldn't it be unmuted if
> you adjust the corresponding mixer element?
> 
> Takashi
> 
> >
> > Thanks.
> > 
> > ------------------ Original ------------------
> > From:  "Takashi Iwai"<tiwai@...e.de>;
> > Date:  Thu, Mar 10, 2022 09:29 PM
> > To:  "huangwenhui"<huangwenhuia@...ontech.com>;
> > Cc:  "perex"<perex@...ex.cz>; "tiwai"<tiwai@...e.com>; "jeremy.szu"
> > <jeremy.szu@...onical.com>; "hui.wang"<hui.wang@...onical.com>; "wse"
> > <wse@...edocomputers.com>; "cam"<cam@...-zeon.de>; "kailang"
> > <kailang@...ltek.com>; "tanureal"<tanureal@...nsource.cirrus.com>; "sami"
> > <sami@...ne.fi>; "alsa-devel"<alsa-devel@...a-project.org>; "linux-kernel"
> > <linux-kernel@...r.kernel.org>;
> > Subject:  Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP
> > machine with alc671
> > 
> > On Thu, 10 Mar 2022 14:03:01 +0100,
> > huangwenhui wrote:
> > >
> > > On a HP 288 Pro G8, the front Mic could not be detected.
> > >
> > > Signed-off-by: huangwenhui <huangwenhuia@...ontech.com>
> >
> > Thanks for the patch.  Most of the changes look OK, but one thing I
> > still don't get:
> >
> > > + case HDA_FIXUP_ACT_INIT:
> > > + alc_write_coef_idx(codec, 0x19, 0xa054);
> > > + msleep(80);
> > > + snd_hda_codec_write(codec, hp_pin, 0,
> > > +     AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);
> >
> > Why this unconditional unmute is required for fixing the mic problem?
> >
> > Takashi
> >
> >
> 
>