linux-kernel - Re: [PATCH] i2c: imx: add irqf_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220311090144.GB9910@pengutronix.de>
Date:   Fri, 11 Mar 2022 10:01:44 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Alifer Moraes <alifer.m@...iscite.com>
Cc:     linux-kernel@...r.kernel.org, pierluigi.p@...iscite.com,
        Fugang Duan <B38611@...escale.com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, gaopan <b54642@...escale.com>,
        linux@...pel-privat.de, eran.m@...iscite.com,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Vipul Kumar <vipul_kumar@...tor.com>, festevam@...il.com,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com
Subject: Re: [PATCH] i2c: imx: add irqf_no_suspend

On Mon, Mar 07, 2022 at 11:36:30AM -0300, Alifer Moraes wrote:
> From: gaopan <b54642@...escale.com>
> 
> The i2c irq is masked when pcie starts a i2c transfer process
> during noirq suspend stage. As a result, i2c transfer fails.
> To solve the problem, IRQF_NO_SUSPEND is added to i2c bus.
> 
> Signed-off-by: Gao Pan <b54642@...escale.com>
> Signed-off-by: Fugang Duan <B38611@...escale.com>
> Signed-off-by: Vipul Kumar <vipul_kumar@...tor.com>

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>
Thank you!

> ---
>  drivers/i2c/busses/i2c-imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 27f969b3dc07..fcc09a1e7f44 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1478,7 +1478,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
>  		goto rpm_disable;
>  
>  	/* Request IRQ */
> -	ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED,
> +	ret = request_threaded_irq(irq, i2c_imx_isr, NULL,
> +				   IRQF_SHARED | IRQF_NO_SUSPEND,
>  				   pdev->name, i2c_imx);
>  	if (ret) {
>  		dev_err(&pdev->dev, "can't claim irq %d\n", irq);
> -- 
> 2.25.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |