[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0fb3795e-0ab1-494b-aefd-ccfa78420723@kernel.org>
Date: Fri, 11 Mar 2022 10:21:46 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Trevor Woerner <twoerner@...il.com>, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-serial@...r.kernel.org
Subject: Re: [PATCH 2/3] serial: 8250_fintek.c: Report chipID
On 11. 03. 22, 8:02, Trevor Woerner wrote:
> Provide some feedback to confirm this driver is enabled, and specify which
> chip was detected.
No, we don't do that. In fact, the output is mostly useless as it
doesn't even tell the user what device this is about.
> Signed-off-by: Trevor Woerner <twoerner@...il.com>
> ---
> drivers/tty/serial/8250/8250_fintek.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index d9f0e546b1a1..03ad2354d808 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -155,11 +155,22 @@ static int fintek_8250_check_id(struct fintek_8250 *pdata)
>
> switch (chip) {
> case CHIP_ID_F81865:
> + pr_info("Fintek F81865\n");
> + break;
> case CHIP_ID_F81866:
> + pr_info("Fintek F81866\n");
> + break;
> case CHIP_ID_F81966:
> + pr_info("Fintek F81966\n");
> + break;
> case CHIP_ID_F81216AD:
> + pr_info("Fintek F81216AD\n");
> + break;
> case CHIP_ID_F81216H:
> + pr_info("Fintek F81216H\n");
> + break;
> case CHIP_ID_F81216:
> + pr_info("Fintek F81216\n");
> break;
> default:
> return -ENODEV;
thanks,
--
js
Powered by blists - more mailing lists