linux-kernel - Re: [GIT PULL] tracing: minor fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220310205057.6769ac0d@gandalf.local.home>
Date:   Thu, 10 Mar 2022 20:50:57 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Bristot de Oliveira <bristot@...nel.org>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Nicolas Saenz Julienne <nsaenzju@...hat.com>
Subject: Re: [GIT PULL] tracing: minor fixes

On Thu, 10 Mar 2022 17:28:31 -0800
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Thu, Mar 10, 2022 at 2:45 PM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> >  - Fix unregistering the same event twice a the user could disable
> >    the event osnoise will disable on unregistering.  
> 
> What? That sounds like a (bad) markov chain text generator made random
> commit noises.
> 
> I tried to edit that to something that actually makes some sense, but
> who knows..

Ah sorry. That was something difficult to shorten, and I wrote that up at
the end of the night.

tracepoints will warn if you try to unregister a callback that is not
registered. It doesn't break anything to do so, but because tracepoints are
asynchronous, and when the user reads the ring buffer it triggers calls to
special functions associated to a tracepoint, unregistering twice usually
is because of a bug that can cause a hard to debug situation. So we warn if
a callback is unregistered from a tracepoint that is not currently
registered.

What happened above is that the osnoise tracer registered callbacks to the
tracepoints. And it unregisters them when the tracer is stopped (echo 0
into tracing_on) or removed (echo nop > current_tracer). If the user stops
osnoise with the echo 0 to tracing_on that will cause the tracepoint
callbacks to be unregistered. If the user then turns off osnoise, then it
will unregister the callbacks again, even though they were no longer
registered.

Basically it was just an accounting error.

-- Steve