linux-kernel - Re: [PATCH] ARM: decompressor: do not copy source files while building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yis7Z90qvPz+EcTk@shell.armlinux.org.uk>
Date:   Fri, 11 Mar 2022 12:07:03 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     patches@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: decompressor: do not copy source files while
 building

On Sun, Oct 31, 2021 at 02:52:58AM +0900, Masahiro Yamada wrote:
> As commit 7ae4a78daacf ("ARM: 8969/1: decompressor: simplify libfdt
> builds") stated, copying source files during the build time may not
> end up with as clean code as expected.
> 
> Do similar for the other library files for further cleanups of the
> Makefile and .gitignore.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Hi,

I am now seeing the following every time I run a build:

  GEN     Makefile
  CALL    .../linux-rmk/scripts/atomic/check-atomics.sh
  CALL    .../linux-rmk/scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  Kernel: arch/arm/boot/Image is ready
  AS      arch/arm/boot/compressed/lib1funcs.o
  AS      arch/arm/boot/compressed/ashldi3.o
  AS      arch/arm/boot/compressed/bswapsdi2.o
  LD      arch/arm/boot/compressed/vmlinux
  OBJCOPY arch/arm/boot/zImage
  Kernel: arch/arm/boot/zImage is ready

In other words, those three objects are always rebuilt even though
they haven't changed.

I've tried removing the arch/arm/boot/compressed directory in the
build tree, but that doesn't make any difference.

Running with V=2 shows:

  AS      arch/arm/boot/compressed/lib1funcs.o - due to lib1funcs.o not in $(tar
gets)
  AS      arch/arm/boot/compressed/ashldi3.o - due to ashldi3.o not in $(targets)
  AS      arch/arm/boot/compressed/bswapsdi2.o - due to bswapsdi2.o not in $(targets)

It looks to me like:
OBJS    += lib1funcs.o ashldi3.o bswapsdi2.o

in your patch should have been added before:

targets       := vmlinux vmlinux.lds piggy_data piggy.o \
                 head.o $(OBJS)

Please confirm.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!