linux-kernel - Re: [PATCH] mm/page_alloc: check high-order pages for corruption during PCP operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220311020206.qncvybld6zrgmm3m@google.com>
Date:   Fri, 11 Mar 2022 02:02:06 +0000
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Mel Gorman <mgorman@...hsingularity.net>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>, Vlastimil Babka <vbabka@...e.cz>,
        Michal Hocko <mhocko@...nel.org>, Wei Xu <weixugc@...gle.com>,
        Greg Thelen <gthelen@...gle.com>,
        Hugh Dickins <hughd@...gle.com>,
        David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] mm/page_alloc: check high-order pages for corruption
 during PCP operations

On Thu, Mar 10, 2022 at 09:24:56AM +0000, Mel Gorman wrote:
> Eric Dumazet pointed out that commit 44042b449872 ("mm/page_alloc: allow
> high-order pages to be stored on the per-cpu lists") only checks the head
> page during PCP refill and allocation operations. This was an oversight
> and all pages should be checked. This will incur a small performance
> penalty but it's necessary for correctness.

> Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored  
> on the per-cpu lists")
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Shakeel Butt <shakeelb@...gle.com>