linux-kernel - Re: [PATCH] perf parse-events: Fix null check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a007c783-49a2-4ab3-a592-9f37ea41eaae@huawei.com>
Date:   Fri, 11 Mar 2022 14:00:13 +0000
From:   John Garry <john.garry@...wei.com>
To:     Weiguo Li <liwg06@...mail.com>, <peterz@...radead.org>,
        <mingo@...hat.com>, <acme@...nel.org>
CC:     <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <namhyung@...nel.org>,
        <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf parse-events: Fix null check

On 11/03/2022 13:06, Weiguo Li wrote:
> We did a null check after "tmp->symbol = strdup(...)", but we checked
> "list->symbol" other than "tmp->symbol".
> 
> Signed-off-by: Weiguo Li <liwg06@...mail.com>

Reviewed-by: John Garry <john.garry@...wei.com>

> ---
>   tools/perf/util/parse-events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 9739b05b999e..dfb50a5f83d0 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -2193,7 +2193,7 @@ int perf_pmu__test_parse_init(void)
>   	for (i = 0; i < ARRAY_SIZE(symbols); i++, tmp++) {
>   		tmp->type = symbols[i].type;
>   		tmp->symbol = strdup(symbols[i].symbol);
> -		if (!list->symbol)
> +		if (!tmp->symbol)
>   			goto err_free;
>   	}
>