linux-kernel - Re: [PATCH] x86/mce: Cover grading of AMD machine error checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18a5a49a-e68f-621e-f8ae-16e794a74905@amd.com>
Date:   Fri, 11 Mar 2022 08:07:23 -0600
From:   Carlos Bilbao <carlos.bilbao@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
        x86@...nel.org, yazen.ghannam@....com,
        linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
        bilbao@...edu
Subject: Re: [PATCH] x86/mce: Cover grading of AMD machine error checks

On 3/10/2022 4:13 PM, Borislav Petkov wrote:
> On Thu, Mar 10, 2022 at 12:24:08PM -0600, Carlos Bilbao wrote:
>> We will cover grading of MCEs like deferred memory scrub errors, attempts 
>> to access poisonous data, etc. I could list all new covered cases in the 
>> commit message if you think that'd be positive.
> 
> So no actual use case - you want to grade error severity for all types
> of MCEs.
> 
>> Hope that helps clarify,
> 
> Yes, it does a bit.
> 
> It sounds to me like you want to do at least two patches:
> 
> 1. Extend the severity grading function with the new types of errors
> 
> 2. Add string descriptions of the error types mce_severity_amd() looks
> at, so that mce_panic() issues them.
> 
> I.e., you want to decode the fatal MCEs which panic the machine.
> 
> In general, what would help is if you think about what you're trying to
> achieve and write it down first. How to achieve that we can figure out
> later.
> 
> What happens now is you send me a patch and I'm trying to decipher from
> the code why you're doing what you're doing. Which is kinda backwards if
> you think about it...
> 

Glad we are on the same page now. I will prepare a pachset and include more
informative commit messages.

Thanks,
Carlos