linux-kernel - Re: [PATCH] clocksource: acpi_pm: fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <760e1916-09cf-11ec-122f-d30e339dca0d@infradead.org>
Date:   Sat, 12 Mar 2022 11:23:42 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        John Stultz <john.stultz@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] clocksource: acpi_pm: fix return value of __setup handler



On 3/11/22 23:09, Dan Carpenter wrote:
> On Tue, Mar 08, 2022 at 08:03:01PM -0800, Randy Dunlap wrote:
>> __setup() handlers should return 1 to obsolete_checksetup() in
>> init/main.c to indicate that the boot option has been handled.
>> A return of 0 causes the boot option/value to be listed as an Unknown
>> kernel parameter and added to init's (limited) environment strings.
>>
>> The __setup() handler interface isn't meant to handle negative return
>> values -- they are non-zero, so they mean "handled" (like a return
>> value of 1 does), but that's just a quirk. So return 1 from
>> parse_pmtmr(). Also print a warning message if kstrtouint() returns
>> an error.
>>
>> Fixes: 60e3bf14d4e2 ("clocksource: clean up parse_pmtmr()")
> 
> I was wondering why I was CC'd on this.
> 
> This fixes tag is wrong...  My patch just cleaned up the function.
> The original code returned negative error codes already.

OK, thanks for the info.

-- 
~Randy