linux-kernel - Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <303ed0c8-8e2c-51a4-a4da-be973a25cdec@gmail.com>
Date:   Sun, 13 Mar 2022 00:43:08 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     shaikh kamal <shaikhkamal2012@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <brauner@...nel.org>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with
 const keyword Warning found by checkpatch.pl script.

Hi Shaikh,

On 3/12/22 23:41, shaikh kamal wrote:
> Signed-off-by: shaikh kamal <shaikhkamal2012@...il.com>
> ---
>   drivers/staging/android/ashmem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index ddbde3f8430e..4c6b420fbf4d 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>   
>   static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>   {
> -	static struct file_operations vmfile_fops;
> +	static const struct file_operations vmfile_fops;
>   	struct ashmem_area *asma = file->private_data;
>   	int ret = 0;
>   

Are you sure this patch compiles? vmfile_fops is overrided few lines below

odd checkpatch.pl warning...




With regards,
Pavel Skripkin