linux-kernel - Re: [RESEND V2] ASoC: max98390: Add reset gpio control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 13 Mar 2022 14:42:50 +0900
From:   Lee Steve <steve.lee.analog@...il.com>
To:     Nuno Sá <noname.nuno@...il.com>
Cc:     lgirdwood@...il.com, Mark Brown <broonie@...nel.org>,
        perex@...ex.cz, tiwai@...e.com, ckeepax@...nsource.cirrus.com,
        geert@...ux-m68k.org, rf@...nsource.wolfsonmicro.com,
        shumingf@...ltek.com, srinivas.kandagatla@...aro.org,
        krzk@...nel.org, jack.yu@...ltek.com,
        "Sa, Nuno" <nuno.sa@...log.com>, ryans.lee@...imintegrated.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [RESEND V2] ASoC: max98390: Add reset gpio control

On Sat, Mar 12, 2022 at 9:58 PM Nuno Sá <noname.nuno@...il.com> wrote:
>
> On Sat, 2022-03-12 at 09:24 +0900, Steve Lee wrote:
> >  Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@...il.com>
> > ---
> >  sound/soc/codecs/max98390.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c
> > b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client
> > *i2c,
> >
> >         struct max98390_priv *max98390 = NULL;
> >         struct i2c_adapter *adapter = i2c->adapter;
> > +       struct gpio_desc *reset_gpio;
> >
> >         ret = i2c_check_functionality(adapter,
> >                 I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> > i2c_client *i2c,
> >                 return ret;
> >         }
> >
> > +       reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> > +                                            "maxim,reset-gpios",
> > GPIOD_OUT_LOW);
>
> A reset GPIO is a standard property so there's no need for a vendor
> prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset",
> ...). And, as said before, you need to add a reset-gpios property to
> the bindings in a different patch.
>
> I'm also not sure why you have this as RESEND...
>
> - Nuno Sá
> >
>

I forgot to add another patch mail. I will check it before sending patch again.