linux-kernel - Re: [PATCH 4.19 00/30] 4.19.235-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yi9X4jqy4RT4jr5n@kroah.com>
Date:   Mon, 14 Mar 2022 15:57:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jon Hunter <jonathanh@...dia.com>,
        James Morse <james.morse@....com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, slade@...dewatkins.com,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 4.19 00/30] 4.19.235-rc1 review

On Mon, Mar 14, 2022 at 02:14:41PM +0000, Jon Hunter wrote:
> 
> On 14/03/2022 14:05, Greg Kroah-Hartman wrote:
> > On Mon, Mar 14, 2022 at 01:58:12PM +0000, Jon Hunter wrote:
> > > Hi Greg,
> > > 
> > > On 14/03/2022 11:34, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 4.19.235 release.
> > > > There are 30 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Wed, 16 Mar 2022 11:27:22 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > > 	https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fpub%2Flinux%2Fkernel%2Fv4.x%2Fstable-review%2Fpatch-4.19.235-rc1.gz&amp;data=04%7C01%7Cjonathanh%40nvidia.com%7C31eb601c0fb5484081d008da05c3aaad%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637828635201758957%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=qkVZnVBxsP8BHFANdvt6NDk8btMPekZoMolKI%2FHK1Zw%3D&amp;reserved=0
> > > > or in the git tree and branch at:
> > > > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > > -------------
> > > > Pseudo-Shortlog of commits:
> > > 
> > > ...
> > > 
> > > > James Morse <james.morse@....com>
> > > >       KVM: arm64: Reset PMC_EL0 to avoid a panic() on systems with no PMU
> > > 
> > > 
> > > The above is causing the following build error for ARM64 ...
> > > 
> > > arch/arm64/kvm/sys_regs.c: In function ‘reset_pmcr’:
> > > arch/arm64/kvm/sys_regs.c:624:3: error: implicit declaration of function ‘vcpu_sys_reg’ [-Werror=implicit-function-declaration]
> > >     vcpu_sys_reg(vcpu, PMCR_EL0) = 0;
> > >     ^~~~~~~~~~~~
> > > arch/arm64/kvm/sys_regs.c:624:32: error: lvalue required as left operand of assignment
> > >     vcpu_sys_reg(vcpu, PMCR_EL0) = 0;
> > > 
> > 
> > Is this also broken in Linus's tree?
> 
> 
> No, Linus' tree is not broken. However, I don't see this change in Linus'
> tree (v5.17-rc8).

Ah, this is a "fix something broken in stable-only" type patch :(

James, I'm dropping this from the 4.19, 4.9, and 4.14 trees right now as
it looks broken :(

thanks,

greg k-h