linux-kernel - Re: [RFC PATCH 04/47] mm: asi: ASI support in interrupts/exceptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmmofs83.ffs@tglx>
Date:   Mon, 14 Mar 2022 16:50:52 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Junaid Shahid <junaids@...gle.com>, linux-kernel@...r.kernel.org
Cc:     kvm@...r.kernel.org, pbonzini@...hat.com, jmattson@...gle.com,
        pjt@...gle.com, oweisse@...gle.com, alexandre.chartre@...cle.com,
        rppt@...ux.ibm.com, dave.hansen@...ux.intel.com,
        peterz@...radead.org, luto@...nel.org, linux-mm@...ck.org
Subject: Re: [RFC PATCH 04/47] mm: asi: ASI support in interrupts/exceptions

On Tue, Feb 22 2022 at 21:21, Junaid Shahid wrote:
>  #define DEFINE_IDTENTRY_RAW(func)					\
> -__visible noinstr void func(struct pt_regs *regs)
> +static __always_inline void __##func(struct pt_regs *regs);		\
> +									\
> +__visible noinstr void func(struct pt_regs *regs)			\
> +{									\
> +	asi_intr_enter();						\

This is wrong. You cannot invoke arbitrary code within a noinstr
section. 

Please enable CONFIG_VMLINUX_VALIDATION and watch the build result with
and without your patches.

Thanks,

        tglx