linux-kernel - Re: [PATCH] mm/mlock: remove unneeded start >= vma->vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yi9qq9hVloDXcW4b@casper.infradead.org>
Date:   Mon, 14 Mar 2022 16:17:47 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, hughd@...gle.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/mlock: remove unneeded start >= vma->vm_end check

On Mon, Mar 14, 2022 at 11:32:23PM +0800, Miaohe Lin wrote:
> If find_vma returns a vma, it must satisfies that start < vma->vm_end.
> Since vma list is sorted in the ascending order, so we will never see
> start >= vma->vm_end here. Remove this unneeded check.

faulty logic; vm_start + len might wrap.