linux-kernel - Re: [PATCH v3 net-next 01/14] net: bridge: mst: Multiple Spanning Tree (MST) mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202203150034.m0Fvevlq-lkp@intel.com>
Date:   Tue, 15 Mar 2022 00:43:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tobias Waldekranz <tobias@...dekranz.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Ivan Vecera <ivecera@...hat.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Russell King <linux@...linux.org.uk>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Cooper Lees <me@...perlees.com>,
        Matt Johnston <matt@...econstruct.com.au>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH v3 net-next 01/14] net: bridge: mst: Multiple Spanning
 Tree (MST) mode

Hi Tobias,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tobias-Waldekranz/net-bridge-Multiple-Spanning-Trees/20220314-175717
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git de29aff976d3216e7f3ab41fcd7af46fa8f7eab7
config: hexagon-randconfig-r041-20220314 (https://download.01.org/0day-ci/archive/20220315/202203150034.m0Fvevlq-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3e4950d7fa78ac83f33bbf1658e2f49a73719236)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/702c502efb27c12860bc55fc8d9b1bfd99466623
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tobias-Waldekranz/net-bridge-Multiple-Spanning-Trees/20220314-175717
        git checkout 702c502efb27c12860bc55fc8d9b1bfd99466623
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/bridge/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/bridge/br.c:269:9: error: implicit declaration of function 'br_mst_set_enabled' [-Werror,-Wimplicit-function-declaration]
                   err = br_mst_set_enabled(br, on, extack);
                         ^
   net/bridge/br.c:269:9: note: did you mean 'br_stp_set_enabled'?
   net/bridge/br_private.h:1828:5: note: 'br_stp_set_enabled' declared here
   int br_stp_set_enabled(struct net_bridge *br, unsigned long val,
       ^
   1 error generated.


vim +/br_mst_set_enabled +269 net/bridge/br.c

   245	
   246	/* br_boolopt_toggle - change user-controlled boolean option
   247	 *
   248	 * @br: bridge device
   249	 * @opt: id of the option to change
   250	 * @on: new option value
   251	 * @extack: extack for error messages
   252	 *
   253	 * Changes the value of the respective boolean option to @on taking care of
   254	 * any internal option value mapping and configuration.
   255	 */
   256	int br_boolopt_toggle(struct net_bridge *br, enum br_boolopt_id opt, bool on,
   257			      struct netlink_ext_ack *extack)
   258	{
   259		int err = 0;
   260	
   261		switch (opt) {
   262		case BR_BOOLOPT_NO_LL_LEARN:
   263			br_opt_toggle(br, BROPT_NO_LL_LEARN, on);
   264			break;
   265		case BR_BOOLOPT_MCAST_VLAN_SNOOPING:
   266			err = br_multicast_toggle_vlan_snooping(br, on, extack);
   267			break;
   268		case BR_BOOLOPT_MST_ENABLE:
 > 269			err = br_mst_set_enabled(br, on, extack);
   270			break;
   271		default:
   272			/* shouldn't be called with unsupported options */
   273			WARN_ON(1);
   274			break;
   275		}
   276	
   277		return err;
   278	}
   279	

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org