lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220314012725.26661-1-rdunlap@infradead.org> Date: Sun, 13 Mar 2022 18:27:25 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: linux-kernel@...r.kernel.org Cc: patches@...ts.linux.dev, Randy Dunlap <rdunlap@...radead.org>, Igor Zhbanov <i.zhbanov@...russia.ru>, Andi Kleen <ak@...ux.intel.com>, Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>, Grzegorz Andrejczuk <grzegorz.andrejczuk@...el.com>, Arjan van de Ven <arjan@...ux.intel.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, x86@...nel.org Subject: [PATCH] x86: fix return value of __setup handlers __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument (no '=') or environment (with '=') strings. So return 1 from these x86 __setup handlers. Examples: Unknown kernel command line parameters "apicpmtimer BOOT_IMAGE=/boot/bzImage-517rc8 vdso=1 ring3mwait=disable", will be passed to user space. Run /sbin/init as init process with arguments: /sbin/init apicpmtimer with environment: HOME=/ TERM=linux BOOT_IMAGE=/boot/bzImage-517rc8 vdso=1 ring3mwait=disable Fixes: 2aae950b21e4 ("x86_64: Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu") Fixes: 77b52b4c5c66 ("x86: add "debugpat" boot option") Fixes: e16fd002afe2 ("x86/cpufeature: Enable RING3MWAIT for Knights Landing") Fixes: b8ce33590687 ("x86_64: convert to clock events") Signed-off-by: Randy Dunlap <rdunlap@...radead.org> Reported-by: Igor Zhbanov <i.zhbanov@...russia.ru> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@...russia.ru Cc: Andi Kleen <ak@...ux.intel.com> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com> Cc: Grzegorz Andrejczuk <grzegorz.andrejczuk@...el.com> Cc: Arjan van de Ven <arjan@...ux.intel.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Ingo Molnar <mingo@...hat.com> Cc: Borislav Petkov <bp@...en8.de> Cc: Dave Hansen <dave.hansen@...ux.intel.com> Cc: Andy Lutomirski <luto@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Cc: x86@...nel.org --- arch/x86/entry/vdso/vma.c | 2 +- arch/x86/kernel/apic/apic.c | 2 +- arch/x86/kernel/cpu/intel.c | 2 +- arch/x86/mm/pat/memtype.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) --- lnx-517-rc8.orig/arch/x86/entry/vdso/vma.c +++ lnx-517-rc8/arch/x86/entry/vdso/vma.c @@ -438,7 +438,7 @@ bool arch_syscall_is_vdso_sigreturn(stru static __init int vdso_setup(char *s) { vdso64_enabled = simple_strtoul(s, NULL, 0); - return 0; + return 1; } __setup("vdso=", vdso_setup); --- lnx-517-rc8.orig/arch/x86/mm/pat/memtype.c +++ lnx-517-rc8/arch/x86/mm/pat/memtype.c @@ -101,7 +101,7 @@ int pat_debug_enable; static int __init pat_debug_setup(char *str) { pat_debug_enable = 1; - return 0; + return 1; } __setup("debugpat", pat_debug_setup); --- lnx-517-rc8.orig/arch/x86/kernel/apic/apic.c +++ lnx-517-rc8/arch/x86/kernel/apic/apic.c @@ -170,7 +170,7 @@ static __init int setup_apicpmtimer(char { apic_calibrate_pmtmr = 1; notsc_setup(NULL); - return 0; + return 1; } __setup("apicpmtimer", setup_apicpmtimer); #endif --- lnx-517-rc8.orig/arch/x86/kernel/cpu/intel.c +++ lnx-517-rc8/arch/x86/kernel/cpu/intel.c @@ -91,7 +91,7 @@ static bool ring3mwait_disabled __read_m static int __init ring3mwait_disable(char *__unused) { ring3mwait_disabled = true; - return 0; + return 1; } __setup("ring3mwait=disable", ring3mwait_disable);
Powered by blists - more mailing lists