linux-kernel - Re: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5107aba4-a03d-a0c9-dc89-0e8472be1bd8@arm.com>
Date:   Mon, 14 Mar 2022 17:55:59 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vladimir Zapolskiy <vz@...ia.com>,
        Kuldeep Singh <singh.kuldeep87k@...il.com>,
        Olof Johansson <olof@...om.net>, SoC Team <soc@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties

On 2022-03-14 12:32, Arnd Bergmann wrote:
> On Mon, Mar 14, 2022 at 1:20 PM Robin Murphy <robin.murphy@....com> wrote:
>> On 2022-03-14 11:50, Vladimir Zapolskiy wrote:
>>> On 3/14/22 1:43 PM, Robin Murphy wrote:
> 
>>>
>>> Thank you, it explains, why "apb_pclk" is required for all PrimeCell
>>> controllers on the SoC. Nevertheless, in commit 93898eb775e5 it was
>>> misidentified with the sspclk clock, the latter one is the only clock
>>> explicitly utilized by the driver in 2015 and till today. Fixes in dts
>>> files should be preceded by a fix in the driver.
>>
>> There's nothing to fix in the driver, though. In fact it can only be
>> working today because the Linux driver isn't very strict and simply
>> assumes that the first clock entry is SSPCLK *without* considering its
>> name (other consumers of the binding might be stricter; I don't know),
>> and because presumably the HCLK happens to be enabled already anyway.
>> Changing the driver behaviour would only stand to cause functional
>> regressions.
> 
> We can change the driver to look for an sspclk by name first, and
> then fall back to the first clk if none is found. This would be backwards
> compatible and allow new dts files to have an arbitrary order, though
> we still need to be careful about changing the existing dts files after
> that, to avoid breaking older kernels.

Yeah, I discounted that since schema is strict about the order of 
entries even when they're named, so we'd have nothing to gain except the 
potential to break compatibility in one direction and annoy users in the 
other. There's little point in having code to look up a clock by name 
when we know that for compatibility reasons it has to be the first 
clock, so it would be functionally identical to the fallback code that 
we also still have to have. All it could offer is additionally printing 
a message about it, and experience says that that achieves little except 
the aforementioned annoyance of users - I look as far as my Rockchip 
boards that have all been screaming an error at me every boot for nearly 
4 years now, where the ethernet driver fails to get a clock that only 
exists on some SoCs *other* than the ones I have :(

Robin.