linux-kernel - Re: [PATCH] aio: drop needless assignment in aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wju=Lx3b5NQ9KntQ=0JvvXcJfpjt_nZOMWV43OWwPrUQw@mail.gmail.com>
Date:   Mon, 14 Mar 2022 11:21:08 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Benjamin LaHaise <bcrl@...ck.org>,
        Alexander Viro <viro@...iv.linux.org.uk>, linux-aio@...ck.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] aio: drop needless assignment in aio_read()

On Mon, Mar 14, 2022 at 8:46 AM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
>
> Drop this needless assignment in aio_read().
>
> No functional change. No change in resulting object code.

Ack, that assignment is indeed dead. As such, compilers will remove it
and it doesn't "hurt", but it is pointless and possibly confusing.

> I cc'ed Linus as he is the author of the referred commit, but I expect
> that this clean-up just goes the usual way to Al Viro and then in some
> git pull to Linus.

Sounds good to me.

                   Linus