linux-kernel - Re: [RFC PATCH v5 005/104] KVM: x86: Refactor KVM VMX module init/exit functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220314192245.GC1964605@ls.amr.corp.intel.com>
Date:   Mon, 14 Mar 2022 12:22:45 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     isaku.yamahata@...el.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, isaku.yamahata@...il.com,
        Jim Mattson <jmattson@...gle.com>, erdemaktas@...gle.com,
        Connor Kuehl <ckuehl@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [RFC PATCH v5 005/104] KVM: x86: Refactor KVM VMX module
 init/exit functions

Thanks for review.

On Sun, Mar 13, 2022 at 02:54:15PM +0100,
Paolo Bonzini <pbonzini@...hat.com> wrote:

> On 3/4/22 20:48, isaku.yamahata@...el.com wrote:
> > -static int __init vmx_init(void)
> > -{
> > -	int r, cpu;
> > +	if (sizeof(struct vcpu_vmx) > *vcpu_size)
> > +		*vcpu_size = sizeof(struct vcpu_vmx);
> > +	if (__alignof__(struct vcpu_vmx) > *vcpu_align)
> > +		*vcpu_align = __alignof__(struct vcpu_vmx);
> 
> Please keep these four lines in vt_init, and rename the rest of
> vmx_pre_kvm_init to hv_vp_assist_page_init.  Likewise, rename
> vmx_post_kvm_exit to hv_vp_assist_page_exit.
> 
> Adjusting the vcpu_size and vcpu_align for TDX (I guess) can be added later
> when TDX ops are introduced.

sure. I'll make it like
  vcpu_size = max(sizeof(struct vcpu_vmx), sizeof(vcpu_tdx));
  ...


Thanks,
-- 
Isaku Yamahata <isaku.yamahata@...il.com>