lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Mar 2022 18:38:08 -0300 From: Jason Gunthorpe <jgg@...dia.com> To: Matthew Rosato <mjrosato@...ux.ibm.com> Cc: linux-s390@...r.kernel.org, alex.williamson@...hat.com, cohuck@...hat.com, schnelle@...ux.ibm.com, farman@...ux.ibm.com, pmorel@...ux.ibm.com, borntraeger@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, gerald.schaefer@...ux.ibm.com, agordeev@...ux.ibm.com, svens@...ux.ibm.com, frankja@...ux.ibm.com, david@...hat.com, imbrenda@...ux.ibm.com, vneethv@...ux.ibm.com, oberpar@...ux.ibm.com, freude@...ux.ibm.com, thuth@...hat.com, pasic@...ux.ibm.com, joro@...tes.org, will@...nel.org, pbonzini@...hat.com, corbet@....net, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org, linux-doc@...r.kernel.org Subject: Re: [PATCH v4 15/32] vfio: introduce KVM-owned IOMMU type On Mon, Mar 14, 2022 at 03:44:34PM -0400, Matthew Rosato wrote: > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 9394aa9444c1..0bec97077d61 100644 > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -77,6 +77,7 @@ struct vfio_iommu { > bool nesting; > bool dirty_page_tracking; > bool container_open; > + bool kvm; > struct list_head emulated_iommu_groups; > }; > > @@ -2203,7 +2204,12 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, > goto out_free_group; > > ret = -EIO; > - domain->domain = iommu_domain_alloc(bus); > + > + if (iommu->kvm) > + domain->domain = iommu_domain_alloc_type(bus, IOMMU_DOMAIN_KVM); > + else > + domain->domain = iommu_domain_alloc(bus); > + > if (!domain->domain) > goto out_free_domain; > > @@ -2552,6 +2558,9 @@ static void *vfio_iommu_type1_open(unsigned long arg) > case VFIO_TYPE1v2_IOMMU: > iommu->v2 = true; > break; > + case VFIO_KVM_IOMMU: > + iommu->kvm = true; > + break; Same remark for this - but more - this is called KVM but it doesn't accept a kvm FD or any thing else to link the domain to the KVM in-use. Jason
Powered by blists - more mailing lists