linux-kernel - Re: [PATCH] scripts/dev-needs: depend on bash in shebang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAGETcx_6BGXFfF1ZHH_=Gq1vp8quFzyLNSCjtfTakJfQE-7Nyw@mail.gmail.com>
Date:   Mon, 14 Mar 2022 15:30:10 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Dirk Müller <dmueller@...e.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] scripts/dev-needs: depend on bash in shebang

Adding LKML

On Mon, Mar 14, 2022 at 3:17 PM Dirk Müller <dmueller@...e.de> wrote:
>
> This script uses bash specific syntax. make it more specific by
> declaring it to be used via bash rather than /bin/sh which could
> be non-bash.
>
> Signed-off-by: Dirk Müller <dmueller@...e.de>

Technically this is targeted towards toybox because that's what I deal
with everyday while I work on Android devices. But toybox seems to
follow bash conventions. Would this shebang be considered valid in
that instance?

Btw, I've been meaning to add (for more than year) the following to
the top of the script:
shopt -s expand_aliases

Geert pointed out that the script doesn't work with some setups
because this flag isn't default enabled. I also remember this being a
deprecated option, but until someone wants to rewrite this script in a
way that it'll work on toybox (this is what Android uses) with zero
setup and also not depend on the aliases, we might as well set the
flag to match with reality.

Wanna pull that shopt into your patch?

-Saravana

> ---
>  scripts/dev-needs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dev-needs.sh b/scripts/dev-needs.sh
> index 454cc304fb44..c324f0737f6b 100755
> --- a/scripts/dev-needs.sh
> +++ b/scripts/dev-needs.sh
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#!/bin/bash
>  # SPDX-License-Identifier: GPL-2.0
>  # Copyright (c) 2020, Google LLC. All rights reserved.
>  # Author: Saravana Kannan <saravanak@...gle.com>
> --
> 2.35.1
>

On Mon, Mar 14, 2022 at 3:17 PM Dirk Müller <dmueller@...e.de> wrote:
>
> This script uses bash specific syntax. make it more specific by
> declaring it to be used via bash rather than /bin/sh which could
> be non-bash.
>
> Signed-off-by: Dirk Müller <dmueller@...e.de>
> ---
>  scripts/dev-needs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dev-needs.sh b/scripts/dev-needs.sh
> index 454cc304fb44..c324f0737f6b 100755
> --- a/scripts/dev-needs.sh
> +++ b/scripts/dev-needs.sh
> @@ -1,4 +1,4 @@
> -#! /bin/sh
> +#!/bin/bash
>  # SPDX-License-Identifier: GPL-2.0
>  # Copyright (c) 2020, Google LLC. All rights reserved.
>  # Author: Saravana Kannan <saravanak@...gle.com>
> --
> 2.35.1
>