linux-kernel - Re: [PATCH] mfd: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY6QYSx7pwxJj87ZwQXExk-E6e3_RXvcHFTQibPJP4k+A@mail.gmail.com>
Date:   Tue, 15 Mar 2022 00:12:35 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     cgel.zte@...il.com
Cc:     lee.jones@...aro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] mfd: Use platform_get_irq() to get the interrupt

On Wed, Mar 9, 2022 at 4:56 AM <cgel.zte@...il.com> wrote:

> From: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>
>
> It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
> for requesting IRQ's resources any more, as they can be not ready yet in
> case of DT-booting.
>
> platform_get_irq() instead is a recommended way for getting IRQ even if
> it was not retrieved earlier.
>
> It also makes code simpler because we're getting "int" value right away
> and no conversion from resource to int is required.
>
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>

OK that is indeed much better code:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij