linux-kernel - Re: [PATCH] RDMA/mlx5: Fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Mar 2022 20:45:11 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Yongzhi Liu <lyz_cs@....edu.cn>
Cc:     leon@...nel.org, yishaih@...lanox.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, fuyq@....pku.edu.cn
Subject: Re: [PATCH] RDMA/mlx5: Fix memory leak

On Fri, Mar 11, 2022 at 09:06:01AM -0800, Yongzhi Liu wrote:
> [why]
> xa_insert is failed, so caller of subscribe_event_xa_alloc
> cannot call other function to free obj_event. Therefore,
> Resource release is needed on the error handling path to
> prevent memory leak.
> 
> [how]
> Fix this by adding kfree on the error handling path.
> 
> Fixes: 7597385 ("IB/mlx5: Enable subscription for device events over DEVX")
> 
> Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
> Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
> ---
>  drivers/infiniband/hw/mlx5/devx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to for-next with Leon's commit message

Thanks,
Jason