linux-kernel - Re: [PATCHv2] net: phy: Kconfig: micrel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yi/VGY+PoiPnBQpJ@lunn.ch>
Date:   Tue, 15 Mar 2022 00:51:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     hkallweit1@...il.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCHv2] net: phy: Kconfig: micrel_phy: fix dependency issue

On Mon, Mar 14, 2022 at 12:02:54PM +0100, Anders Roxell wrote:
> When building driver CONFIG_MICREL_PHY the follow error shows up:
> 
> aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_ts_info':
> micrel.c:(.text+0x1764): undefined reference to `ptp_clock_index'
> micrel.c:(.text+0x1764): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-gnu-ld: drivers/net/phy/micrel.o: in function `lan8814_probe':
> micrel.c:(.text+0x4720): undefined reference to `ptp_clock_register'
> micrel.c:(.text+0x4720): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
> 
> Rework Kconfig for MICREL_PHY to depend on 'PTP_1588_CLOCK_OPTIONAL'.
> Arnd describes in a good way why its needed to add this depends in patch
> e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies").
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew