linux-kernel - Re: [PATCH] media: meson-ir-tx: fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <846c8a4f-73ed-5003-1c7c-578d580a9833@baylibre.com>
Date:   Mon, 14 Mar 2022 09:02:19 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Yihao Han <hanyihao@...o.com>, Sean Young <sean@...s.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     kernel@...o.com
Subject: Re: [PATCH] media: meson-ir-tx: fix platform_get_irq.cocci warning

On 10/03/2022 08:40, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
> 
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
> 
> Signed-off-by: Yihao Han <hanyihao@...o.com>
> ---
>   drivers/media/rc/meson-ir-tx.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c
> index 63e1dbf0a4e9..abdb62b16e98 100644
> --- a/drivers/media/rc/meson-ir-tx.c
> +++ b/drivers/media/rc/meson-ir-tx.c
> @@ -323,10 +323,8 @@ static int __init meson_irtx_probe(struct platform_device *pdev)
>   		return PTR_ERR(ir->reg_base);
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "no irq resource found\n");
> +	if (irq < 0)
>   		return -ENODEV;
> -	}
>   
>   	ir->dev = dev;
>   	ir->carrier = MIRTX_DEFAULT_CARRIER;

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>